Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'overwrite_ports' config option #5355

Closed
wants to merge 1 commit into from

Conversation

shcallaway
Copy link

@shcallaway shcallaway commented Nov 8, 2017

An alternative to the overwrite_multivals config option proposed in #5354 .

In your docker-compose.override.yml, the overwrite_ports config option allows you to toggle whether ports should be concatenated with the base (false) or overwritten (true).

This PR is a work in progress. Todo:

  • compose/config/validation.py
  • Unit tests
  • Documentation

@shcallaway
Copy link
Author

Closing because this particular design won't be approved. I may revisit this feature in the future.

@shcallaway shcallaway closed this Jan 11, 2019
@shcallaway shcallaway deleted the overwrite_ports branch January 11, 2019 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant