Check for short id alias, and don't disconnect if it already exists #3337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
|
@friism when used with moby/moby#21901 this should be working. You can grab the binary from the appveyor build when it completes. |
Signed-off-by: Daniel Nephin <[email protected]>
dnephin
force-pushed
the
check_for_short_id_alias
branch
from
625be1d to
56c6e29
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3252
Related to moby/libnetwork#996 and moby/moby#21901
Windows engine doesn't have network disconnect, so we can check if the short id alias already exists, and skip the disconnect if it does exist.
cc @friism, @mavenugo