WIP: Bump 1.5.2 #2491
Merged
WIP: Bump 1.5.2 #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mazz Mosley <[email protected]>
Credit to @funkyfuture for the first PR addressing the clarification. docker#1767 Signed-off-by: Mazz Mosley <[email protected]>
…host port Signed-off-by: Viranch Mehta <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
…ars to compose container Signed-off-by: Simon van der Veldt <[email protected]>
Signed-off-by: Stefan Scherer <[email protected]>
…objects. Previously these empty objects would hit a bug in splitting objects causing it crash. With this fix the empty objects are returned properly. Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Stéphane Seguin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Brandon Burton <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
…ll tests don't flake. Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
project name is already normalized to a valid name before creating a service. Signed-off-by: Daniel Nephin <[email protected]>
Includes creating a new compose.config.types module for all the domain objects. Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
At the same time, moves extra_hosts validation to the config module. Signed-off-by: Daniel Nephin <[email protected]>
This removes the last of the old service.ConfigError Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
|
Nice. Any idea what's going on with the test failures? I guess the |
Split env resolving into two phases. The first phase is to expand the paths of env_files, which is done before merging extends. Once all files are merged together, the final phase is to read the env_files and use them as the base for environment variables. Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Jonas Eckerström <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
We were essentially only testing that *at least one* of the invalid values fails the validation check, rather than that *all* of them fail. Signed-off-by: Aanand Prasad <[email protected]>
Signed-off-by: Aanand Prasad <[email protected]>
- The `raises` kwarg to the `cls_check` decorator was being used incorrectly (it should be an exception class, not an object). - We need to check for `error.cause` and get the message out of the exception object. NB: The particular case where validation fails in the case of `ports` is only when ranges don't match in length - no further validation is currently performed client-side. Signed-off-by: Aanand Prasad <[email protected]>
Signed-off-by: Aanand Prasad <[email protected]>
Signed-off-by: Aanand Prasad <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
|
I figured out the test failure. There was a refactoring done between two sets of changes which added |
Signed-off-by: Daniel Nephin <[email protected]>
|
Fixed the wording in the changelog as well. Once janky runs green I think this is ready to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.