2221 allow empty environment keys #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was missing a space between the different types, when there were 3 possible type values. Signed-off-by: Mazz Mosley <[email protected]>
| @@ -143,7 +143,7 @@ def _parse_valid_types_from_validator(validator): | |||
| if len(validator) >= 2: | |||
| first_type = anglicize_validator(validator[0]) | |||
| last_type = anglicize_validator(validator[-1]) | |||
| types_from_validator = "{}{}".format(first_type, ", ".join(validator[1:-1])) | |||
| types_from_validator = "{}".format(", ".join([first_type] + validator[1:-1])) | |||
There was a problem hiding this comment.
I think the "{}".format() is unnecessary now? it could be:
types_from_validator = ", ".join([first_type] + validator[:-1])Environment keys that contain no value, get populated with values taken from the environment not from the build phase but from running the command `up`. Signed-off-by: Mazz Mosley <[email protected]>
mnowster
force-pushed
the
2221-blank-env-vars
branch
from
e3d8ef5 to
08add66
Compare
|
LGTM, that test failure is a flake I see locally pretty often. I'll wait for janky to re-run before merge. |
|
And I opened a github issue about it a while ago: moby/moby#15995 |
|
Build is green after another run |
dnephin
added a commit
that referenced
this pull request
Oct 19, 2015
2221 allow empty environment keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2221