Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add global flag to define download directory for remote configuration (oci & git) #12521

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

glours
Copy link
Contributor

@glours glours commented Feb 3, 2025

What I did
Add a --download-dir flag to choose the directory were remote configurations (OCI or git) will be downloaded
This flag throws an error if there is no -f or --file mentioning oci:// or git:// resources.

The flag is hidden for now

Related issue
https://docker.atlassian.net/browse/APCLI-881

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@glours glours requested a review from a team as a code owner February 3, 2025 16:04
@glours glours requested a review from ndeloof February 3, 2025 16:04
@glours glours force-pushed the download-dir-oci-artifact branch from 2fa6eb8 to 580d575 Compare February 3, 2025 16:04
Copy link
Contributor

@ndeloof ndeloof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM regarding the codebase, I just wonder this will just bring issues once we will try to offer remote loader cache management (cleanup)

@glours glours force-pushed the download-dir-oci-artifact branch from 580d575 to ee59ba3 Compare February 3, 2025 16:14
@glours glours marked this pull request as draft February 3, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants