use service.stop to stop dependent containers #12322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
reviewed
Nov 25, 2024
pkg/compose/convergence.go
Outdated
| Services: dependents, | ||
| Project: project, | ||
| }) | ||
| return err |
There was a problem hiding this comment.
Suggested change
| return err | |
| if err != nil { | |
| return err | |
| } |
There was a problem hiding this comment.
For once I didn't used golang snipet for error management, here is the result 😅
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
stop_dependent_containers
branch
from
800ccb2
to
eddfaa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
as we detect a service must be recreated, use
composeService.stopto stop them following dependency tree and with concurrent operations where possible.Related issue
fixes #12310
(not mandatory) A picture of a cute animal, if possible in relation to what you did