add gui/composeview as part of available commands #11851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrotko
reviewed
May 23, 2024
internal/tracing/keyboard_metrics.go
Outdated
| commandAvailable := []string{} | ||
| if isDockerDesktopActive { | ||
| commandAvailable = append(commandAvailable, "gui") | ||
| } | ||
| if isWatchConfigured { | ||
| commandAvailable = append(commandAvailable, "watch") | ||
| } | ||
|
|
||
| if isDDComposeUI { |
There was a problem hiding this comment.
for consistency with isDockerDesktopActive I would change it to isDockerDesktopComposeUI
jhrotko
reviewed
May 23, 2024
internal/tracing/keyboard_metrics.go
Outdated
| commandAvailable := []string{} | ||
| if isDockerDesktopActive { | ||
| commandAvailable = append(commandAvailable, "gui") | ||
| } | ||
| if isWatchConfigured { | ||
| commandAvailable = append(commandAvailable, "watch") | ||
| } | ||
|
|
||
| if isDDComposeUI { |
There was a problem hiding this comment.
Suggested change
| if isDDComposeUI { | |
| if isDockerDesktopComposeUI { |
jhrotko
approved these changes
May 23, 2024
Signed-off-by: Guillaume Lours <[email protected]>
glours
force-pushed
the
add-compose-ui-command-tracking
branch
from
88535f2 to
0d6ac18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add the new open configuration menu to the list of available commands in navmenu metrics
Related issue
N/A
(not mandatory) A picture of a cute animal, if possible in relation to what you did