Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump buildx to v0.12.0 and adapt code to changes #11217

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

glours
Copy link
Contributor

@glours glours commented Nov 22, 2023

What I did
Bump to buildx v0.12.0

I did the minimal changes to build, we could, in a follow up PR, decide to use directly the new DisplayMode instead of a string (I didn't check possible side effects for now)

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@glours glours requested a review from ndeloof November 22, 2023 17:53
@glours glours self-assigned this Nov 22, 2023
@glours glours added the dependencies Pull requests that update a dependency file label Nov 22, 2023
@glours glours force-pushed the bump-buildx-v0.12.0 branch 2 times, most recently from 863f412 to dfd7017 Compare November 22, 2023 18:22
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a1aceba) 56.78% compared to head (8a9d220) 56.84%.

Files Patch % Lines
cmd/compose/run.go 0.00% 1 Missing ⚠️
cmd/compose/up.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11217      +/-   ##
==========================================
+ Coverage   56.78%   56.84%   +0.06%     
==========================================
  Files         133      133              
  Lines       11491    11491              
==========================================
+ Hits         6525     6532       +7     
+ Misses       4329     4323       -6     
+ Partials      637      636       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndeloof ndeloof merged commit c665c53 into docker:main Nov 23, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants