warn user remote resource is disabled #11051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
warn_remote_disabled
branch
from
8ae00fe
to
fe8c278
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11051 +/- ##
==========================================
+ Coverage 57.55% 57.73% +0.18%
==========================================
Files 129 129
Lines 11237 11245 +8
==========================================
+ Hits 6467 6492 +25
+ Misses 4141 4127 -14
+ Partials 629 626 -3
☔ View full report in Codecov by Sentry. |
glours
approved these changes
Sep 29, 2023
Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Guillaume Lours <[email protected]>
ndeloof
commented
Oct 18, 2023
| @@ -114,51 +114,51 @@ func (g ociRemoteLoader) Load(ctx context.Context, path string) (string, error) | |||
| return "", err | |||
| } | |||
|
|
|||
| s, err2 := g.pullComposeFiles(ctx, local, composeFile, manifest, ref, resolver) | |||
There was a problem hiding this comment.
could also rename variable err
|
Sorry I see your comment too late 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
as user forgot (?) to enable git/oci remote resource support (still experimental) compose tries to resolve a local path from URL. This is obvious something is wrong, but the way to get this fixed isn't.
this PR let the remote resource loader detect it should load a remote resource, but report an explicit error and way to fix it.