Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove --timeout=0 flag to cleanup function of watch e2e test #11023

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

glours
Copy link
Contributor

@glours glours commented Sep 19, 2023

compose down command need the watch process to be killed to succeed

What I did
Fix the watch e2e tests which fails during the cleanup stage

Related issue
https://github.com/docker/compose/actions/runs/6240098754/job/16939441138

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

compose down command need the watch process to be killed to succeed

Signed-off-by: Guillaume Lours <[email protected]>
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.59% 🎉

Comparison is base (421a6b0) 57.38% compared to head (e00fdd9) 57.98%.

❗ Current head e00fdd9 differs from pull request most recent head 61c8be1. Consider uploading reports for the commit 61c8be1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11023      +/-   ##
==========================================
+ Coverage   57.38%   57.98%   +0.59%     
==========================================
  Files         129      129              
  Lines       11227    11121     -106     
==========================================
+ Hits         6443     6448       +5     
+ Misses       4151     4040     -111     
  Partials      633      633              

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glours glours merged commit 75f5c07 into docker:main Sep 20, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants