Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to github.com/distribution/reference #10954

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

thaJeztah
Copy link
Member

What I did

The "reference" package was moved to a separate module, which was extracted
from distribution/distribution@b9b1940

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@thaJeztah
Copy link
Member Author

thaJeztah commented Aug 31, 2023

Looks like the distribution-types made their way into compose's signatures, so we need to wait for distribution to have that PR merged, and I'll also open a PR in compose-go

#21 142.4 cmd/main.go:33:2: could not import github.com/docker/compose/v2/pkg/compose (-: # github.com/docker/compose/v2/pkg/compose
#21 142.4 pkg/compose/compose.go:154:32: cannot use func(named reference.Named) (digest.Digest, error) {…} (value of type func(named "github.com/distribution/reference".Named) (digest.Digest, error)) as func(named "github.com/distribution/distribution/v3/reference".Named) (digest.Digest, error) value in argument to project.ResolveImages) (typecheck)
#21 142.4 	"github.com/docker/compose/v2/pkg/compose"
#21 142.4 	^

@thaJeztah
Copy link
Member Author

@ndeloof I kept it in draft because there was no tagged version of compose-go with this patch; do you want to have a tagged version first?

(:warning: not sure if that should be 1.18.x or if we want to be on the safe side, and to 1.19.0 so that we could still do 1.18.x patch releases without this switch)

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06% ⚠️

Comparison is base (32c3d0a) 58.32% compared to head (4a9d78b) 58.26%.

❗ Current head 4a9d78b differs from pull request most recent head f4f2e93. Consider uploading reports for the commit f4f2e93 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10954      +/-   ##
==========================================
- Coverage   58.32%   58.26%   -0.06%     
==========================================
  Files         124      124              
  Lines       10912    10912              
==========================================
- Hits         6364     6358       -6     
- Misses       3918     3923       +5     
- Partials      630      631       +1     
Files Changed Coverage Δ
pkg/compose/compose.go 61.32% <ø> (ø)
pkg/compose/image_pruner.go 79.83% <ø> (ø)
pkg/compose/images.go 72.60% <ø> (ø)
pkg/compose/pull.go 75.62% <ø> (ø)
pkg/compose/push.go 13.04% <ø> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The "reference" package was moved to a separate module, which was extracted
from distribution/distribution@b9b1940

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah marked this pull request as ready for review September 4, 2023 12:37
@thaJeztah
Copy link
Member Author

compose-go v1.18.4 was tagged; moved this out of draft

@glours glours merged commit 203bce8 into docker:main Sep 4, 2023
23 checks passed
@thaJeztah thaJeztah deleted the swap_reference branch September 4, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants