Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: watch e2e reliability tweaks #10829

Merged
merged 2 commits into from
Jul 19, 2023
Merged

test: watch e2e reliability tweaks #10829

merged 2 commits into from
Jul 19, 2023

Conversation

milas
Copy link
Contributor

@milas milas commented Jul 18, 2023

What I did

  • Skip on macOS until upstream fix is merged
  • Do not run in parallel to avoid trouble in CI

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did
racoon snout booping the camera

Fix forthcoming via compose-spec/compose-go#436
which addresses some symlink limitations. These can
actually effect other platforms but are most common
on macOS because the test creates temporary directories,
which are symlinked on macOS.

Signed-off-by: Milas Bowman <[email protected]>
This isn't playing nicely with the GHA CI runner.

Signed-off-by: Milas Bowman <[email protected]>
@milas milas requested a review from a team July 18, 2023 22:57
@milas milas self-assigned this Jul 18, 2023
@milas milas requested review from nicksieger, ndeloof, StefanScherer, ulyssessouza, glours and laurazard and removed request for a team July 18, 2023 22:57
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06 🎉

Comparison is base (0938c7e) 59.25% compared to head (ddceb1a) 59.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10829      +/-   ##
==========================================
+ Coverage   59.25%   59.31%   +0.06%     
==========================================
  Files         115      115              
  Lines        9869     9869              
==========================================
+ Hits         5848     5854       +6     
+ Misses       3430     3426       -4     
+ Partials      591      589       -2     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit 150b88a into docker:v2 Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants