use --progress to configure progress UI style
#10690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
ndeloof
force-pushed
the
progress
branch
2 times, most recently
from
8a7ac24 to
1f20407
Compare
milas
approved these changes
Jun 12, 2023
ndeloof
force-pushed
the
progress
branch
2 times, most recently
from
a32915f to
000d3a3
Compare
|
@milas made a last minute update : to avoid |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10690 +/- ##
==========================================
- Coverage 58.98% 58.85% -0.14%
==========================================
Files 111 112 +1
Lines 9716 9740 +24
==========================================
+ Hits 5731 5732 +1
- Misses 3399 3419 +20
- Partials 586 589 +3
☔ View full report in Codecov by Sentry. |
Signed-off-by: Nicolas De Loof <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Introduce
--progresstop-level flag to configure progress UI as auto|tty|plain|quiet|noneThis allows to have explicit control on the progress UI without using
--ansiflag which also has impact on logs renderingbuildalready declared this flag. It is now redundant and kept for backward compatibility but marked hiddenRelated issue
see #10686
(not mandatory) A picture of a cute animal, if possible in relation to what you did