Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dry-run support to down command #10444

Merged
merged 1 commit into from
Apr 7, 2023
Merged

add dry-run support to down command #10444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/api/dryrunclient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ func (d *DryRunClient) ImagePush(ctx context.Context, ref string, options moby.I
}

func (d *DryRunClient) ImageRemove(ctx context.Context, imageName string, options moby.ImageRemoveOptions) ([]moby.ImageDeleteResponseItem, error) {
return nil, ErrNotImplemented
return nil, nil
}

func (d *DryRunClient) NetworkConnect(ctx context.Context, networkName, container string, config *network.EndpointSettings) error {
Expand All @@ -229,15 +229,15 @@ func (d *DryRunClient) NetworkDisconnect(ctx context.Context, networkName, conta
}

func (d *DryRunClient) NetworkRemove(ctx context.Context, networkName string) error {
return ErrNotImplemented
return nil
}

func (d *DryRunClient) VolumeCreate(ctx context.Context, options volume.CreateOptions) (volume.Volume, error) {
return volume.Volume{}, ErrNotImplemented
}

func (d *DryRunClient) VolumeRemove(ctx context.Context, volumeID string, force bool) error {
return ErrNotImplemented
return nil
}

func (d *DryRunClient) ContainerExecCreate(ctx context.Context, container string, config moby.ExecConfig) (moby.IDResponse, error) {
Expand Down