Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress writer uses dockercli.Err stream #10366

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Mar 13, 2023

What I did
Pass dockerCli.Err() to NewWriter so it uses relevant streams vs os.Stderr
benefits doing so is that it helps configure and capture output on e2e tests

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage: 73.33% and project coverage change: +0.03 🎉

Comparison is base (fc4d2df) 53.32% compared to head (7731644) 53.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10366      +/-   ##
==========================================
+ Coverage   53.32%   53.36%   +0.03%     
==========================================
  Files         104      104              
  Lines        8911     8911              
==========================================
+ Hits         4752     4755       +3     
+ Misses       3640     3638       -2     
+ Partials      519      518       -1     
Impacted Files Coverage Δ
pkg/compose/kill.go 0.00% <0.00%> (ø)
pkg/compose/push.go 0.00% <0.00%> (ø)
pkg/compose/up.go 90.32% <ø> (ø)
cmd/compose/compose.go 74.14% <50.00%> (ø)
pkg/compose/pause.go 43.47% <50.00%> (ø)
cmd/compose/version.go 73.33% <66.66%> (ø)
pkg/progress/writer.go 64.61% <71.42%> (ø)
cmd/compose/run.go 68.47% <100.00%> (ø)
pkg/compose/build.go 78.15% <100.00%> (ø)
pkg/compose/create.go 58.38% <100.00%> (ø)
... and 6 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ndeloof ndeloof requested review from a team, nicksieger, StefanScherer, ulyssessouza, glours, milas and laurazard and removed request for a team March 13, 2023 08:11
@ndeloof ndeloof merged commit bbe1b77 into docker:v2 Mar 15, 2023
@ndeloof ndeloof deleted the progress_streams branch March 15, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants