add dry-run support for pull command #10341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder: should dry-run on pull check the image exists and is accessible with configured credentials, but not actually pull, or just do nothing as proposed here ? |
|
Right! I'll add the check of the image existence and that the user is granted to pull it |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## v2 #10341 +/- ##
=======================================
Coverage 74.18% 74.18%
=======================================
Files 2 2
Lines 275 275
=======================================
Hits 204 204
Misses 60 60
Partials 11 11 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
glours
force-pushed
the
dry-run-pull-support
branch
from
b545ff9 to
b6a142b
Compare
ndeloof
approved these changes
Mar 3, 2023
glours
force-pushed
the
dry-run-pull-support
branch
from
b6a142b to
c04cd9d
Compare
Signed-off-by: Guillaume Lours <[email protected]>
glours
force-pushed
the
dry-run-pull-support
branch
from
c04cd9d to
3f7d3c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add dry run support to
pullcommandRelated issue
https://docker.atlassian.net/browse/ENV-62
(not mandatory) A picture of a cute animal, if possible in relation to what you did
