watch: ignore ephemeral files & minor output tweaks #10311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KDE's text editor, kate, uses a file similar to Vim's .swp files. Ignore these files so we don't rebuild on every keypress. Fixes docker#3378
This follows the "action-first" approach to use the apiserver model for `FileWatch` and dispatch simple create/update/delete actions.
When creating files in Go, the stdlib will create (and then rapidly delete) files ending with `-go-tmp-umask` to determine the umask to use for permission purposes. This can cause trouble with Live Update because the files tend to vanish underneath it, for example. Fixes docker#5117.
Currently the emacs ignore patterns include `**/.#*` (lock files), but doesn't include `**/#*#` (autosave files; https://www.emacswiki.org/emacs/AutoSave, not to be confused with `**/*~` backup files which are ignored.) Add autosave files.
milas
requested review from
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
glours and
laurazard
and removed request for
a team
Codecov ReportBase: 73.89% // Head: 73.89% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## v2 #10311 +/- ##
=======================================
Coverage 73.89% 73.89%
=======================================
Files 2 2
Lines 272 272
=======================================
Hits 201 201
Misses 60 60
Partials 11 11 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Big change here is to import the ephemeral ignore set from Tilt. The `.git` directory is also ignored for now: this restriction should probably be lifted and made configurable in the future, but it's not generally important to watch and triggers a LOT of events (e.g. Git creates `index.lock` files that will appear and disappear rapidly as terminals/IDEs/etc interact with Git, even for read-only operations). The Tilt-provided ephemeral file set has been slowly devised over time based on temporary files that can cause trouble. We can also look at a more robust/configurable solution here in the future, but thse provide a reasonable out-of-the-box configuration for the moment. There's also some small tweaks to the output to add missing newlines in a few edge cases and such. Signed-off-by: Milas Bowman <[email protected]>
ndeloof
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Big change here is to import the ephemeral ignore set from Tilt.
The
.gitdirectory is also ignored for now: this restrictionshould probably be lifted and made configurable in the future,
but it's not generally important to watch and triggers a LOT of
events (e.g. Git creates
index.lockfiles that will appear anddisappear rapidly as terminals/IDEs/etc interact with Git, even
for read-only operations).
The Tilt-provided ephemeral file set has been slowly devised over
time based on temporary files that can cause trouble. We can also
look at a more robust/configurable solution here in the future,
but thse provide a reasonable out-of-the-box configuration for
the moment.
There's also some small tweaks to the output to add missing
newlines in a few edge cases and such.
(not mandatory) A picture of a cute animal, if possible in relation to what you did
