Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce --wait-timeout on up #10276

Merged
merged 1 commit into from
Feb 14, 2023
Merged

introduce --wait-timeout on up #10276

merged 1 commit into from
Feb 14, 2023

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Feb 13, 2023

What I did
Introduce --timeout to prevent compose up to be stuck

Related issue
closes #10269

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@ndeloof ndeloof force-pushed the wait_timeout branch 2 times, most recently from 5a2566d to f01bfc1 Compare February 14, 2023 10:11
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 73.89% // Head: 73.89% // No change to project coverage 👍

Coverage data is based on head (f01bfc1) compared to base (0612b34).
Patch has no changes to coverable lines.

❗ Current head f01bfc1 differs from pull request most recent head ad3a2b8. Consider uploading reports for the commit ad3a2b8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##               v2   #10276   +/-   ##
=======================================
  Coverage   73.89%   73.89%           
=======================================
  Files           2        2           
  Lines         272      272           
=======================================
  Hits          201      201           
  Misses         60       60           
  Partials       11       11           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Nicolas De Loof <[email protected]>
@ndeloof ndeloof changed the title introduce --timeout on up introduce --wait-timeout on up Feb 14, 2023
@ndeloof ndeloof requested review from a team, nicksieger, StefanScherer, ulyssessouza, glours, milas and laurazard and removed request for a team February 14, 2023 10:48
Copy link
Contributor

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add timeout to --wait option
2 participants