fix: remove invalid cache-from registry entries #10135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Würbach <[email protected]>
johanneswuerbach
force-pushed
the
rm-cache-from-registry
branch
from
79ab2b6 to
8400199
Compare
ndeloof
approved these changes
Apr 24, 2023
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
|
@johanneswuerbach sorry for the laaaaaate review on this PR. Could you please rebase your branch to fix conflict ? |
|
Looks like this was already fixed in #10374 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
When specifying:
docker compose currently translates this into
--cache-from type=gha --cache-from type=registry,ref=type=gha, which causes a warning.This PR removes the explicit addition of
type=registry, which shouldn't be necessary as the cache flag parsing handles this case already https://github.com/docker/buildx/blob/25ceb9067893be764f9ab439722835eece2fe169/util/buildflags/cache.go#L22This code was originally added in 70694e1, but I couldn't find any mention why it would be necessary.
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did