Switch to golang:1.8.4-alpine3.6 #633
Conversation
|
I understand this takes up more space on our machines but I think the benefit of being able to do multi-arch things more than makes up for some |
|
These are the "dev" and "lint" images; given that we don't do any multi-arch in this repository, wondering if this change should be in the packaging repo |
|
The problem with non-alpine images isn't so much the space, more that downloading the base image and installing packages is much slower, which makes CI much slower. (not sure why CI hasn't run yet on this PR) Can't we just wait for gliderlabs/docker-alpine#337 which will give us alpine multi-arch? It sounds like it's almost ready. |
|
Alternatively, I think we could build our own mutli-arch golang alpine image and use that until the official one is ready. |
|
@thaJeztah We already use Instead we could just do a: |
|
@seemethere I agree we should eventually move to that; my concern was that that change would currently be a step back for the way the image is used in this repo; is there a real urgency to change it right now? |
|
@thaJeztah Our workarounds seem to work for now but it'd be nice to eventually get multi-arch support in the CLI repo outside of the |
|
Yes, once the multi-arch golang-alpine images are ready it should "just work" without us having to make any changes. |
|
Alpine is multi arch now; gliderlabs/docker-alpine#352 |
|
Golang is almost there as well; docker-library/official-images#3624 |
|
golang is there now too 🎉 Just tested with |
|
Great, so I guess we just need to change the base image to |
|
I will update the PR later today!! |
|
@seemethere is there any change needed to the current version in this repo? Those should now automatically pick the right architecture, correct? |
|
oh, never mind; we wanted to bump to alpine 3.6 |
golang:1.8.4-alpine does not have multi-arch images available in the manifest. (s390x, ppc64le, etc.) This makes it so that if you are trying to compile on different arches you aren't forced to have to write your own Dockerfile and can instead use the one bundled with the CLI repo. Signed-off-by: Eli Uriegas <[email protected]>
seemethere
force-pushed
the
switch_to_multi_arch_images
branch
from
371f696 to
9d1d9f2
Compare
|
Updated with a bump to |
Codecov Report
@@ Coverage Diff @@
## master #633 +/- ##
========================================
- Coverage 49.69% 49.4% -0.3%
========================================
Files 209 208 -1
Lines 17258 17190 -68
========================================
- Hits 8577 8493 -84
- Misses 8255 8264 +9
- Partials 426 433 +7 |
|
@seemethere go1.8.5 was just released |
Signed-off-by: Eli Uriegas [email protected]
- What I did
golang:1.8.4-alpine does not have multi-arch images available in the
manifest. (s390x, ppc64le, etc.)
This makes it so that if you are trying to compile on different
arches you aren't forced to have to write your own Dockerfile and can
instead use the one bundled with the CLI repo.
- How I did it
Switch the images to
golang:1.8.4-alpine3.6and switch the package management commands toapt-get- How to verify it
make -f docker.Makefile binary- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
