cmd/docker: add cause to user-terminated context.Context
#5760
+47
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a "cause" to the `context.Context` error when the user terminates the process through SIGINT/SIGTERM. This allows us to distinguish the cause of the `context.Context` cancellation. In future we would also be able to improve the UX of printed errors based on the underlying cause. Signed-off-by: Alano Terblanche <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5760 +/- ##
==========================================
- Coverage 59.47% 59.42% -0.05%
==========================================
Files 346 347 +1
Lines 29367 29433 +66
==========================================
+ Hits 17465 17491 +26
- Misses 10929 10969 +40
Partials 973 973 |
vvoland
reviewed
Jan 21, 2025
vvoland
reviewed
Jan 24, 2025
Signed-off-by: Alano Terblanche <[email protected]>
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Signed-off-by: Alano Terblanche <[email protected]>
Benehiko
force-pushed
the
user-terminated-ctx-err
branch
from
8839f12 to
bdd630c
Compare
ndeloof
approved these changes
Jan 29, 2025
fayazkhan121
approved these changes
Jan 29, 2025
Benehiko
force-pushed
the
user-terminated-ctx-err
branch
from
1cad6c0 to
da5701e
Compare
|
Please don't merge yet, this is incorrect. We need to have status 130 print when a container exits with that code. |
Benehiko
force-pushed
the
user-terminated-ctx-err
branch
from
da5701e to
bdd630c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a "cause" to the
context.Contexterror when the user terminates the process through SIGINT/SIGTERM.This allows us to distinguish the cause of the
context.Contextcancellation. In future we would also be able to improve the UX of printed errorsbased on the underlying cause.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)