Remove leading and trailing double quotes from environment variable values in docker run commands #5434
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Implemented functionality to automatically remove leading and trailing double quotes from environment variable values when they are set via the Docker CLI (
docker run
). This enhancement prevents issues caused by unintended double quotes in environment variable values, ensuring that the variables are set correctly inside containers.- How I did it
opts/file.go
,opts/parse.go
to strip leading and trailing double quotes from environment variable values.strings.Trim
with"
as the cutset to remove only the leading and trailing double quotes without affecting any internal quotes within the value.cli/command/container/opts_test.go
to verify that leading and trailing double quotes are correctly removed.- How to verify it
Build the Docker CLI from the modified source code.
Run a container with an environment variable that includes leading and trailing double quotes in its value:
Expected output:
some value with spaces