change TestNewAPIClientFromFlagsWithHttpProxyEnv to an e2e test #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
move_proxy_test_to_e2e
branch
2 times, most recently
from
f7c0643 to
0019cda
Compare
Codecov Report
@@ Coverage Diff @@
## master #3221 +/- ##
=======================================
Coverage 58.58% 58.58%
=======================================
Files 299 299
Lines 21502 21502
=======================================
Hits 12597 12597
Misses 7983 7983
Partials 922 922 |
Golang uses a `sync.Once` when determining the proxy to use. This means that it's not possible to test the proxy configuration in unit tests, because the proxy configuration will be "fixated" the first time Golang detects the proxy configuration. This patch changes TestNewAPIClientFromFlagsWithHttpProxyEnv to an e2e test so that we can verify the CLI picks up the proxy configuration. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
move_proxy_test_to_e2e
branch
from
0019cda to
40c6b11
Compare
This was referenced Jul 29, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #3197
Golang uses a
sync.Oncewhen determining the proxy to use. This meansthat it's not possible to test the proxy configuration in unit tests,
because the proxy configuration will be "fixated" the first time Golang
detects the proxy configuration.
This patch changes TestNewAPIClientFromFlagsWithHttpProxyEnv to an e2e
test, so that we can verify the CLI picks up the proxy configuration.