add Makefile #3
Merged
add Makefile #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should try and keep "targets that run inside a container" in a separate file from "targets that build images or run containers". Anyone who wants to run the "inside a container" targets on their host can do that by pointing at the right Maybe we can have |
dnephin
reviewed
Apr 24, 2017
dockerfiles/Dockerfile.build
Outdated
| @@ -2,6 +2,7 @@ | |||
| FROM golang:1.8-alpine | |||
|
|
|||
| RUN apk add -U git | |||
| RUN apk add -U make | |||
There was a problem hiding this comment.
Looks like formatting is off a bit here because of tabs vs spaces
dnephin
reviewed
Apr 24, 2017
Makefile
Outdated
|
|
||
| # build the cli | ||
| build: | ||
| go build -o ./build/docker ./cmd/docker |
There was a problem hiding this comment.
To build all the binaries we can do this:
gox -output build/docker-{{.OS}}-{{.Arch}}
-osarch="linux/arm linux/amd64 darwin/amd64 windows/amd64"
./cmd/docker
There was a problem hiding this comment.
Thanks! Used it for the "cross" target :)
Merged
dnephin
reviewed
Apr 24, 2017
dockerfiles/Dockerfile.build
Outdated
| @@ -2,6 +2,7 @@ | |||
| FROM golang:1.8-alpine | |||
|
|
|||
| RUN apk add -U git | |||
| RUN apk add -U make | |||
There was a problem hiding this comment.
This should be one line:
RUN apk add -U git make
gdevillele
force-pushed
the
add-makefile
branch
from
3b75584 to
9cc53cc
Compare
Signed-off-by: Gaetan de Villele <[email protected]>
gdevillele
force-pushed
the
add-makefile
branch
from
9cc53cc to
fb41398
Compare
vdemeester
pushed a commit
to vdemeester/docker-cli
that referenced
this pull request
Oct 13, 2017
Add deploy command, kubernetes version
thaJeztah
added a commit
that referenced
this pull request
Oct 4, 2021
[20.10 backport] Update Go to 1.16.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started to write a Makefile for this repo.
This is still WIP, comments are welcome.
@dnephin Thanks for your Dockerfile! #1
Signed-off-by: Gaetan de Villele [email protected]