-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing CLI plugins API documentation #2534
Conversation
… it is now deprecated. Adding depreciation notice. Signed-off-by: Silvin Lubecki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -50,6 +50,7 @@ The table below provides an overview of the current status of deprecated feature | |||
|
|||
Status | Feature | Deprecated | Remove | |||
-----------|------------------------------------------------------------------------------------------------------------------------------------|------------|------------ | |||
Deprecated | [CLI plugins support](#cli-plugins-support) | v20.03.0 | - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for disturbing you.
Does the deprecated CLI plugins support
mean not to open this function to users (it is not recommended that users develop their own plugins), or does it mean that its function will be completely removed? For example docker buildx
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't be removed (at least not in the short term) so that (e.g.) buildx can continue to work.
Can someone please provide more context for this? - if you're going to deprecate something we use (and we do), we'd like to know a reason, if there's a plan to replace it, or whatever.... I was working towards simplifying internal use of more complicated workflows using cli plugins, but this kinda comes out of the blue for me. I presume there is more context :) |
Hi @SvenDowideit, I gave some context here and there is discussion there. Essentially we do not want to fragment the Docker CLI UX and plugins as they are currently structured will cause that. Paths forward are to upstream features that make sense to be upstreamed or build standalone tools for things that are too niche. We are looking at how to make our platform more extendable and this feedback helps us do so. |
mmm, I guess the saddest thing is that there wasn't a GitHub discussion about this - I felt that the CLI plugins were the best step to allow users to prototype ideas to make sure they were worth the work to upstream - and a great place for site specific tooling. Removing the documentation when the API is deprecated is also not really right - the process (er, used to be) to not remove until after the deprecation period was up - as it makes it hard to debug and fix existing and working plugins - it basically mind-wipes the docs. |
- What I did
Adding depreciation notice for the CLI Plugins API.
- A picture of a cute animal (not mandatory but encouraged)