Exposes compose loader.Transform function…
#1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdemeester
force-pushed
the
expose-compose-transform
branch
3 times, most recently
from
02c234e to
4e60601
Compare
vdemeester
force-pushed
the
expose-compose-transform
branch
from
4e60601 to
ebe2821
Compare
Codecov Report
@@ Coverage Diff @@
## master #1244 +/- ##
==========================================
- Coverage 54.23% 54.23% -0.01%
==========================================
Files 268 268
Lines 17807 17809 +2
==========================================
Hits 9658 9658
- Misses 7542 7543 +1
- Partials 607 608 +1 |
thaJeztah
approved these changes
Jul 30, 2018
cli/compose/loader/loader.go
Outdated
| @@ -265,11 +265,13 @@ func getServices(configDict map[string]interface{}) map[string]interface{} { | |||
| return map[string]interface{}{} | |||
| } | |||
|
|
|||
| func transform(source map[string]interface{}, target interface{}) error { | |||
| // Transform convert the source map into the target struct with compose types transformer | |||
This should make it easier for people to write custom composefile parser without duplicating too much code. It takes the default transformers and any additional number of transformer for any types. That way it's possible to transform a `cli/compose` map into a custom type that would use some of `cli/compose` types and its own. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
expose-compose-transform
branch
from
ebe2821 to
0246bc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier for people to write custom composefile
parser without duplicating too much code. It takes the default
transformers and any additional number of transformer for any
types. That way it's possible to transform a
cli/composemap into acustom type that would use some of
cli/composetypes and its own.Really useful to remove some duplication in
docker/app👼 🙏Signed-off-by: Vincent Demeester [email protected]