docker -H /var/run/docker.sock always fail

[simonferquel]

Description

In master, top level flags are parsed twice. This is not a problem for single value flags, but for lists (such as -H), it create duplicate values, which cause issues. As an example, setting -H currently breaks the CLI

Steps to reproduce the issue:

1. run docker -H /var/run/docker.sock version

Describe the results you received:

Please specify only one -H

Describe the results you expected:

normal version output

Output of docker version:

current master

cc @thaJeztah @silvin-lubecki @vdemeester @ijc

[thaJeztah]

possible suspect #1722

[ijc]

I thing I know what is wrong here, will look at it today

[ijc]

Apart from this issue (which I will fix), why is -H an array if you can only pass it once?

[thaJeztah]

Apart from this issue (which I will fix), why is -H an array if you can only pass it once?

It's in common.go;

cli/cli/flags/common.go

Line 73 in 48bd4c6

flags.VarP(hostOpt, "host", "H", "Daemon socket(s) to connect to")

I suspect this is technical debt, from the time that the cli and daemon were in the same repository (and same binary), and some flags were re-used for the cli and daemon-cli 😓

I think all of common.go should be moved/integrated into the other parts of the code

[ijc]

Are you aware of any other list-based global options I could use for an e2e (since if the global -H is fixed to not be a list then an e2e test based on it wouldn't be effective any longer...). I don't see any in that common.go nor in cli/cobra.go

[thaJeztah]

hm... no, don't think there's any 🤔

[ijc]

OK, nevermind, I'll cope ;-)