re-introduced support for port numbers in docker registry URL

Signed-off-by: Carston Schilds <[email protected]> (cherry picked from commit 2380481) Signed-off-by: Sebastiaan van Stijn <[email protected]>
docker · Jun 26, 2024 · 217971d · 217971d
1 parent fce24d5
commit 217971d
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/cli/config/credentials/file_store.go b/cli/config/credentials/file_store.go
@@ -74,7 +74,10 @@ func ConvertToHostname(maybeURL string) string {
 	if strings.Contains(stripped, "://") {
 		u, err := url.Parse(stripped)
 		if err == nil && u.Hostname() != "" {
-			return u.Hostname()
+			if u.Port() == "" {
+				return u.Hostname()
+			}
+			return u.Hostname() + ":" + u.Port()
 		}
 	}
 	hostName, _, _ := strings.Cut(stripped, "/")

diff --git a/cli/config/credentials/file_store_test.go b/cli/config/credentials/file_store_test.go
@@ -167,6 +167,23 @@ func TestConvertToHostname(t *testing.T) {
 			input:    "ftp://example.com",
 			expected: "example.com",
 		},
+		// should support non-standard port in registry url
+		{
+			input:    "example.com:6555",
+			expected: "example.com:6555",
+		},
+		{
+			input:    "http://example.com:6555",
+			expected: "example.com:6555",
+		},
+		{
+			input:    "https://example.com:6555",
+			expected: "example.com:6555",
+		},
+		{
+			input:    "https://example.com:6555/v2/",
+			expected: "example.com:6555",
+		},
 	}
 	for _, tc := range tests {
 		tc := tc