Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: dial session directly with http hijack #804

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

tonistiigi
Copy link
Member

This enables better performance for session transfers for docker driver by avoiding double grpc. Ensures that docker/cli#3314 does not have lower performance on the default path.

Signed-off-by: Tonis Tiigi [email protected]

@tonistiigi
Copy link
Member Author

tonistiigi commented Oct 18, 2021

upstream pr moby/buildkit#2419 merged

@tonistiigi tonistiigi added this to the v0.7.0 milestone Oct 18, 2021
@tonistiigi tonistiigi force-pushed the http-hijack-session branch 2 times, most recently from 837416b to 3e4eaee Compare October 18, 2021 20:25
@tonistiigi tonistiigi marked this pull request as ready for review October 18, 2021 20:25
@AkihiroSuda
Copy link
Collaborator

Needs rebase

@AkihiroSuda AkihiroSuda merged commit 89f5c1c into docker:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants