include default ssh socket when given an ssh-based git url #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Couture-Beil <[email protected]>
|
@tonistiigi here's my changes to make use of moby/buildkit#2056 I'm unsure how I should update go.mod; if I run |
|
@alexcb You can just update to go.mod file to point to the sha and then run |
- updated buildkit to current code in master via: go mod edit -require github.com/moby/buildkit@master && go mod tidy && ./hack/update-vendor Signed-off-by: Alex Couture-Beil <[email protected]>
|
thanks for guiding me through the process @tonistiigi , I wasn't sure if it was expected for this PR to end up being 312 files changed. |
tonistiigi
approved these changes
Apr 2, 2021
alexcb
added a commit
to alexcb/cli-1
that referenced
this pull request
Apr 13, 2021
…d line - fixes moby/buildkit#2040 with a similar fix which was done in docker/buildx#581 Signed-off-by: Alex Couture-Beil <[email protected]>
alexcb
added a commit
to alexcb/cli-1
that referenced
this pull request
Apr 13, 2021
- this fixes moby/buildkit#2040 by enabling ssh forwarding when a remote address is given on the command line, this is a similar fix to docker/buildx#581 Signed-off-by: Alex Couture-Beil <[email protected]>
alexcb
added a commit
to alexcb/cli-1
that referenced
this pull request
Apr 21, 2021
- this fixes moby/buildkit#2040 by enabling ssh forwarding when a remote address is given on the command line, this is a similar fix to docker/buildx#581 Signed-off-by: Alex Couture-Beil <[email protected]>
alexcb
added a commit
to alexcb/cli-1
that referenced
this pull request
Apr 21, 2021
- this fixes moby/buildkit#2040 by enabling ssh forwarding when a remote address is given on the command line, this is a similar fix to docker/buildx#581 Signed-off-by: Alex Couture-Beil <[email protected]>
alexcb
added a commit
to alexcb/cli-1
that referenced
this pull request
Apr 21, 2021
- this fixes moby/buildkit#2040 by enabling ssh forwarding when a remote address is given on the command line, this is a similar fix to docker/buildx#581 Signed-off-by: Alex Couture-Beil <[email protected]>
alexcb
added a commit
to alexcb/cli-1
that referenced
this pull request
Aug 19, 2021
- this fixes moby/buildkit#2040 by enabling ssh forwarding when a remote address is given on the command line, this is a similar fix to docker/buildx#581 Signed-off-by: Alex Couture-Beil <[email protected]>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Aug 19, 2021
- this fixes moby/buildkit#2040 by enabling ssh forwarding when a remote address is given on the command line, this is a similar fix to docker/buildx#581 Signed-off-by: Alex Couture-Beil <[email protected]> Upstream-commit: af1bb80c3482d1395123af3037bb5ecf5feb5a7e Component: cli
crazy-max
pushed a commit
to crazy-max/docker-cli
that referenced
this pull request
Mar 24, 2023
- this fixes moby/buildkit#2040 by enabling ssh forwarding when a remote address is given on the command line, this is a similar fix to docker/buildx#581 Signed-off-by: Alex Couture-Beil <[email protected]> (cherry picked from commit af1bb80)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Couture-Beil [email protected]