Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

history(inspect): print build name #2931

Closed
wants to merge 1 commit into from

Conversation

crazy-max
Copy link
Member

Prints build name for history inspect command so it can relate with the history ls one.

@tonistiigi
Copy link
Member

Name is not an actual field of the build. It's a reduction of a collection of fields in the same short string. Inspect should show the original fields with full values.

@crazy-max
Copy link
Member Author

Name is not an actual field of the build. It's a reduction of a collection of fields in the same short string. Inspect should show the original fields with full values.

This is needed for the build summary in GHA: https://github.com/docker/actions-toolkit/blob/e6e18dee2531192e00536d6f21c792e6d01c0b3a/src/github.ts#L272-L299

image

And if we are following this logic then we should do the same for Build Steps no?

Build Steps:    59/59 (69% cached)

would be smth like:

Completed Steps:    59
Total Steps:        59
Cached Steps:       35

@tonistiigi
Copy link
Member

And if we are following this logic then we should do the same for Build Steps no?

If we have JSON formatting in the future then step counters would be separate fields there.

This is needed for the build summary in GHA:

This can be done based on other fields, or if needed we can add it in JSON output. But no reason to show (partial) duplicates to the user.

@crazy-max crazy-max closed this Jan 20, 2025
@crazy-max crazy-max removed this from the v0.20.0 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants