-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bake: support null arg and label value #1449
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including a null value in a string template is not yet supported: variable "GO_VERSION" {
default = null
}
target "default" {
args = {
GO_VERSION = "${GO_VERSION}-alpine"
}
} This will lead to:
We could convert to the expected type. |
crazy-max
commented
Dec 3, 2022
crazy-max
force-pushed
the
bake-var-null
branch
from
December 3, 2022 16:53
0e86cf9
to
528b1be
Compare
crazy-max
force-pushed
the
bake-var-null
branch
from
December 5, 2022 13:32
528b1be
to
0e0dd0f
Compare
crazy-max
force-pushed
the
bake-var-null
branch
2 times, most recently
from
December 5, 2022 21:33
deac246
to
2ad47c0
Compare
crazy-max
changed the title
bake: support null args
bake: support null arg and labels value
Dec 5, 2022
crazy-max
changed the title
bake: support null arg and labels value
bake: support null arg and label value
Dec 5, 2022
crazy-max
force-pushed
the
bake-var-null
branch
2 times, most recently
from
December 8, 2022 19:06
0eadb81
to
3ba3dc2
Compare
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
bake-var-null
branch
from
December 14, 2022 07:32
3ba3dc2
to
fe76a1b
Compare
tonistiigi
approved these changes
Dec 15, 2022
This was referenced Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up #1362 (comment)
In this example,
GO_VERSION
arg will always be sent in the request and overwrites the one in the Dockerfile. Therefore build would fail asGO_VERSION
will be empty.With this PR,
null
type is now handled and will set the arg only if set:Signed-off-by: CrazyMax [email protected]