Refactor builder and drivers info logic #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
builder-pkg
branch
from
8930e23 to
d3a0a07
Compare
jedevc
reviewed
Nov 28, 2022
This comment was marked as resolved.
This comment was marked as resolved.
crazy-max
force-pushed
the
builder-pkg
branch
from
d3a0a07 to
94e1113
Compare
crazy-max
changed the title
This was referenced Nov 30, 2022
crazy-max
force-pushed
the
builder-pkg
branch
3 times, most recently
from
e4df400 to
1062c23
Compare
crazy-max
force-pushed
the
builder-pkg
branch
from
1062c23 to
24b093a
Compare
jedevc
approved these changes
Dec 6, 2022
build/build.go
Outdated
|
|
||
| func filterAvailableDrivers(drivers []DriverInfo) ([]DriverInfo, error) { | ||
| out := make([]DriverInfo, 0, len(drivers)) | ||
| func filterAvailableDrivers(nodes []builder.Node) ([]builder.Node, error) { |
There was a problem hiding this comment.
Suggested change
| func filterAvailableDrivers(nodes []builder.Node) ([]builder.Node, error) { | |
| func filterAvailableNodes(nodes []builder.Node) ([]builder.Node, error) { |
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
builder-pkg
branch
from
24b093a to
cc01caa
Compare
Comment on lines
+60
to
+61
| func(i int, n store.Node) { | ||
| eg.Go(func() error { |
There was a problem hiding this comment.
The code would be easier to read if at least one of these annonymous function was tunred into a mehtod.
There was a problem hiding this comment.
Yes agree, I put a comment on this method so we can track this as follow-up: https://github.com/docker/buildx/pull/1430/files#diff-7c6ac5bb2a9c2322f716d7b66113042e64298fbdc5cba600abed692a0c2a6570R38
errordeveloper
approved these changes
Dec 6, 2022
Closed
tonistiigi
reviewed
Jan 11, 2023
| if b.err == nil && err != nil { | ||
| b.err = err | ||
| } | ||
| _, _ = b.LoadNodes(timeoutCtx, true) |
There was a problem hiding this comment.
Why is this ignoring the error instead of setting it to the builder?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves builder and drivers info logic from
commandspkg to a dedicated client pkg so we can easily interact with builders and drivers. Refactoring reduced latency for operations when loading drivers data or checking already validated endpoints:Added some TODOs as there is still room for improvements.