Support new tar option for oci+docker exporters
#1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
requested changes
Nov 23, 2022
There was a problem hiding this comment.
Replace directive for moby needs to match buildkit one:
Line 171 in 60e2029
replace github.com/docker/docker => github.com/docker/docker v20.10.3-0.20221006005007-99aa9bb766b5+incompatible // 22.06 branch (v22.06-dev)
Signed-off-by: Justin Chadwell <[email protected]>
Signed-off-by: Justin Chadwell <[email protected]>
Signed-off-by: Justin Chadwell <[email protected]>
crazy-max
approved these changes
Nov 28, 2022
|
Get this one in, as follow-up we should have unit tests for this package: https://github.com/docker/buildx/blob/master/util/buildflags |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⬆️ Follow-up to moby/buildkit#3162
moby/buildkit#3162 requires changes to buildx, as it requires improved validation in the CLI to correctly determine whether it should pass a file or a directory to the buildkit server. Additionally, we need to update the buildkit vendored packages for the updated client-side validation.