Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands: use buildx env for experimental opt-in #1267

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

tonistiigi
Copy link
Member

I messed this up when doing the final review edits for #1100

Signed-off-by: Tonis Tiigi [email protected]

@tonistiigi tonistiigi added this to the v0.9.0 milestone Aug 12, 2022
@jedevc jedevc merged commit fb5e139 into docker:master Aug 16, 2022
@crazy-max
Copy link
Member

Missed

if v, ok := os.LookupEnv("BUILDKIT_EXPERIMENTAL"); ok {

Also don't think we need to say BUILDX_EXPERIMENTAL=1 is required. for this flag as it's hidden behind the isExperimental() cond anyway.

@jedevc
Copy link
Collaborator

jedevc commented Aug 16, 2022

Woops, we should definitely be consistent with keeping BUILDX_EXPERIMENTAL=1 is required. between --invoke and --print. I think some sort of (experimental) note after both would be nice though - just to indicate that it has been activated with the isExperimental condition.

@crazy-max
Copy link
Member

@jedevc Sgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants