Remote driver connhelpers #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedevc
force-pushed
the
remote-driver-connhelpers
branch
from
12bb4bc to
447be8b
Compare
Yes, include the k8s one too. |
jedevc
force-pushed
the
remote-driver-connhelpers
branch
from
447be8b to
96eccab
Compare
AkihiroSuda
reviewed
May 20, 2022
| @@ -5,8 +5,8 @@ go 1.17 | |||
| require ( | |||
| github.com/compose-spec/compose-go v1.2.4 | |||
| github.com/containerd/console v1.0.3 | |||
| github.com/containerd/containerd v1.6.3-0.20220401172941-5ff8fce1fcc6 | |||
There was a problem hiding this comment.
not sure this change is needed in this PR
There was a problem hiding this comment.
buildkit master has updated to containerd v1.6.4, I think that's why this gets bumped? https://github.com/moby/buildkit/blob/master/go.mod#L11
tonistiigi
reviewed
May 24, 2022
jedevc
force-pushed
the
remote-driver-connhelpers
branch
from
a25e86b to
3ff06ba
Compare
Update modules: go mod edit -require github.com/moby/buildkit@master go mod tidy -compat=1.17 && ./hack/update-vendor Signed-off-by: Justin Chadwell <[email protected]>
jedevc
force-pushed
the
remote-driver-connhelpers
branch
from
3ff06ba to
1406ff1
Compare
Signed-off-by: Justin Chadwell <[email protected]>
Signed-off-by: Justin Chadwell <[email protected]>
tonistiigi
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch pulls in the
sshanddocker-containerconnhelpers from buildkit to allow connections oversshand to manageddocker-containers.I was thinking we pull in at least the
docker-containerandsshhelpers, and maybe thekubepodone?I've also attempted to update the buildkit dependency to pull in moby/buildkit#2843 - though in doing so that's also bumped some other things, so not entirely sure whether that's the right way to go.