Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for build - test - push workflow #733

Closed
francisdb opened this issue Aug 17, 2021 · 4 comments
Closed

Support for build - test - push workflow #733

francisdb opened this issue Aug 17, 2021 · 4 comments

Comments

@francisdb
Copy link

francisdb commented Aug 17, 2021

For https://github.com/hseeberger/scala-sbt we have an extra test step between building and pushing. There we validate that the images work as expected.

As I understand it there is no way to have a 2-step process for building and pushing, and using the default docker push will fail as it does not find the images.
Also we need to add the push argument depending on the pr-or-not fact

Maybe a docker docker buildx push command can be added, with the user repeating the --platform argument to pick the correct images?
Any other workarounds for this?

This is similar to #724

@crazy-max
Copy link
Member

Similar to docker/build-push-action#269. I will add some doc on build-push-action repo with this use case.

@flotwig
Copy link

flotwig commented Jun 29, 2022

Been really struggling with this (and I consider myself an intermediate Docker user), I'm surprised there's no simple way to QA multi-arch images before pushing.

@crazy-max are you sure this is a dupe of docker/build-push-action#269? I read that issue and am still in the dark as to how to do this. The --load option used in those docs does not seem to work with multi-arch images.

@crazy-max
Copy link
Member

@flotwig
Copy link

flotwig commented Jun 29, 2022

@crazy-max Let me know if I'm mistaken in my interpretation here - I did read that, but this example only appears to build+test one arch, and then it does a multi-arch build and pushes that to the registry. How about if I want to test all architectures I'm building images for instead of only one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants