Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can I integrate with container-structure-test? #269

Closed
felipecrs opened this issue Jan 6, 2021 · 4 comments · Fixed by #455
Closed

How can I integrate with container-structure-test? #269

felipecrs opened this issue Jan 6, 2021 · 4 comments · Fixed by #455

Comments

@felipecrs
Copy link

Most likely it would require a new input, such as:

pre-publish-command: container-structure-test --image test/image

@crazy-max
Copy link
Member

crazy-max commented Feb 16, 2021

@felipecrs We could add an input in this action but I think this should be handled by buildx first. WDYT @tonistiigi?

@felipecrs
Copy link
Author

felipecrs commented Aug 24, 2021

It does not need to be like I said, if there is any other approach that could help with integrating test tools would be really helpful. Maybe even a new guide in the advanced topics would do the trick.

@corey-dawson
Copy link

It also makes sense to me to add a pre-publish docker run command to run test scipts within the built container, where the image would not be pushed if the test step fails

@felipecrs
Copy link
Author

Furthermore, it's not exactly concern of this repository, but I wonder how could it be integrated with buildx bake as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants