bake: allow dot in target name

Signed-off-by: CrazyMax <[email protected]>
docker · Mar 17, 2022 · 8f61bfb · 8f61bfb
1 parent 1ca30a5
commit 8f61bfb
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/bake/bake.go b/bake/bake.go
@@ -28,7 +28,7 @@ var (
 	httpPrefix                   = regexp.MustCompile(`^https?://`)
 	gitURLPathWithFragmentSuffix = regexp.MustCompile(`\.git(?:#.+)?$`)
 
-	validTargetNameChars = `[a-zA-Z0-9_-]+`
+	validTargetNameChars = `[a-zA-Z0-9._-]+`
 	targetNamePattern    = regexp.MustCompile(`^` + validTargetNameChars + `$`)
 )
 

diff --git a/bake/bake_test.go b/bake/bake_test.go
@@ -1011,7 +1011,7 @@ func TestTargetName(t *testing.T) {
 		},
 		{
 			target:  "a.b",
-			wantErr: true,
+			wantErr: false,
 		},
 		{
 			target:  "_a",

diff --git a/bake/compose_test.go b/bake/compose_test.go
@@ -330,7 +330,7 @@ func TestServiceName(t *testing.T) {
 		},
 		{
 			svc:     "a.b",
-			wantErr: true,
+			wantErr: false,
 		},
 		{
 			svc:     "_a",