buildx: error editing nodes with driver opts/config file

Currently, editing nodes to contain a new set of driver options or config files is unsupported, so we want to explicitly mark it as so, instead of silently failing to set those options. In the future, we might support overriding these options, however, for now, we should give the user visability of the supported options. Signed-off-by: Justin Chadwell <[email protected]>
docker · Jul 27, 2022 · 50cf979 · 50cf979
1 parent 832d90c
commit 50cf979
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/commands/create.go b/commands/create.go
@@ -300,6 +300,9 @@ func createCmd(dockerCli command.Cli) *cobra.Command {
 }
 
 func csvToMap(in []string) (map[string]string, error) {
+	if len(in) == 0 {
+		return nil, nil
+	}
 	m := make(map[string]string, len(in))
 	for _, s := range in {
 		csvReader := csv.NewReader(strings.NewReader(s))

diff --git a/store/nodegroup.go b/store/nodegroup.go
@@ -70,6 +70,12 @@ func (ng *NodeGroup) Update(name, endpoint string, platforms []string, endpoints
 		if flags != nil {
 			n.Flags = flags
 		}
+		if do != nil {
+			return errors.Errorf("cannot update node with new driver options")
+		}
+		if configFile != "" {
+			return errors.Errorf("cannot update node with new config file")
+		}
 		ng.Nodes[i] = n
 		if err := ng.validateDuplicates(endpoint, i); err != nil {
 			return err