Detail .dockerignore is ignored in git context #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvalentiate
force-pushed
the
detail_ignore_of_dockerignore
branch
2 times, most recently
from
c3d5046 to
907441c
Compare
crazy-max
reviewed
Jul 13, 2021
dvalentiate
force-pushed
the
detail_ignore_of_dockerignore
branch
from
23c9f93 to
b38f358
Compare
Add a note to README.md that .dockerignore is not processed by default by build-push-action@v2. Signed-off-by: David Valentiate <[email protected]> Co-authored-by: CrazyMax <[email protected]> Signed-off-by: David Valentiate <[email protected]>
dvalentiate
force-pushed
the
detail_ignore_of_dockerignore
branch
from
b38f358 to
e80adc3
Compare
|
@crazy-max thanks for the review. I added your suggestion of "`" around |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a note to README.md that .dockerignore is not processed by default by build-push-action@v2.
This issue was raised in this issue Inconsistent dockerignore behavior from other builders but no action was taken.
My team lost hours because
.dockerignoreis ignored unlesscontext: .. This behaviour is different from expectations of all my team, and now we must update many projects. I hope this PR can help others avoid wasting so much time on an unexpected situation.