Add example to update DockerHub repo description #117
Conversation
Signed-off-by: CrazyMax <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=======================================
Coverage 44.85% 44.85%
=======================================
Files 3 3
Lines 107 107
Branches 17 17
=======================================
Hits 48 48
Misses 46 46
Partials 13 13 Continue to review full report at Codecov.
|
| name: Update repo description | ||
| uses: peter-evans/dockerhub-description@v2 | ||
| env: | ||
| DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }} |
There was a problem hiding this comment.
Isn't it the same user and password? I think you should reuse the secrets.
There was a problem hiding this comment.
@felipecrs As stipulated by the Docker Hub Description action, you cannot use a DockerHub Token to update the description. That's why I don't use the same credentials here. More info: https://github.com/peter-evans/dockerhub-description#usage
There was a problem hiding this comment.
Maybe the DOCKER_PASSWORD should be renamed as DOCKER_TOKEN so :)
There was a problem hiding this comment.
@felipecrs DOCKER_PASSWORD can be used as docker login too but yeah good idea to use DOCKER_TOKEN as best practice. I will update the README about this.
Closes #21
Signed-off-by: CrazyMax [email protected]