Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tar extract file modified time #916

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ffais
Copy link

@ffais ffais commented Aug 22, 2024

I added the --touch flag as targetTarArgs to prevent the "Cannot utime: Operation not supported" error message from appearing, especially when some storage types (e.g. Azure FileShare) are used on Kubernetes.

@tianon
Copy link
Member

tianon commented Aug 23, 2024

Hmm, I think copying the mtime is generally desirable, even if only cosmetic. I guess I wish there was a "try to preserve mtime but don't fail if you can't" flag. 😞

@ffais
Copy link
Author

ffais commented Aug 28, 2024

A solution could be to introduce a flag like "unsupportedmtime=true|false" and add the touch argument based on that, instead of setting it by default.

Something like that:


	if [ "$unsupportedmtime" != 'false' ]; then
			targetTarArgs+=(
				--touch
			)
	fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants