Add fpm-alpine variant #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this? Alpine based images are a lot smaller. |
|
I think there are a few bugs to resolve in the |
|
ping @ncopa @yosifkit could you take a look at my attempt to fix docker-library/php#206 (comment) with docker-library/php#237? |
|
ping @ncopa docker-library/php#245 review welcome ;) |
| && docker-php-ext-configure gd --with-png-dir=/usr --with-jpeg-dir=/usr \ | ||
| && docker-php-ext-install gd mysqli opcache \ | ||
| && find /usr/local/lib/php/extensions -name '*.a' -delete \ | ||
| && find /usr/local/lib/php/extensions -name '*.so' -exec strip --strip-all '{}' \; \ |
There was a problem hiding this comment.
Given that PHP's own Dockerfile strips all the executables it installs, I wonder if it wouldn't be more appropriate for docker-php-ext-install to do so as well (certainly would be more appropriate IMO to do this there generally than to do so here as a special case).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on docker-library/php/pull/176