Fix non-root support #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testing ruby:2.3.0
'utc' [1/9]...passed
'cve-2014--shellshock' [2/9]...passed
'no-hard-coded-passwords' [3/9]...passed
'override-cmd' [4/9]...passed
'ruby-hello-world' [5/9]...passed
'ruby-standard-libs' [6/9]...passed
'ruby-gems' [7/9]...passed
'ruby-bundler' [8/9]...passed
'ruby-nonroot' [9/9]...passed |
tianon
added a commit
to tianon/docker-jruby
that referenced
this pull request
Feb 4, 2016
Sorry, I messed this up in what should've been kind of an obvious way, and now it's much more robust and should actually work properly. 👍 See docker-library/ruby#69 for more context.
|
LGTM (instead of waiting for travis, I'll be doing a buildtest on docker-library/official-images#1417 anyway) |
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Feb 4, 2016
- `docker`: 1.10.0 - `golang`: 1.6rc2 - `julia`: keep `curl` for `Pkg.add` (docker-library/julia#6) - `kibana`: add `tini` for signal capturing (docker-library/kibana#32) - `ruby`: allow non-root usage trivially (docker-library/ruby#68, docker-library/ruby#69)
Closed
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
- `docker`: 1.10.0 - `golang`: 1.6rc2 - `julia`: keep `curl` for `Pkg.add` (docker-library/julia#6) - `kibana`: add `tini` for signal capturing (docker-library/kibana#32) - `ruby`: allow non-root usage trivially (docker-library/ruby#68, docker-library/ruby#69)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a little 🐑ish... This was writing to
/root/.bundle/config, and using environment variables before they existed. Since Bundler supports environment variables for all settings, let's use those instead so that this actually works properly. 👍Fixes the shortcoming of #68 (for backlink references).