Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BUNDLE_BIN and add GEM_HOME/bin back to PATH #209

Merged
merged 1 commit into from
May 24, 2018
Merged

Remove BUNDLE_BIN and add GEM_HOME/bin back to PATH #209

merged 1 commit into from
May 24, 2018

Conversation

tianon
Copy link
Member

@tianon tianon commented May 21, 2018

See #208 (comment)

This is a follow-up to #208.

Refs #188, #191, #193

@tianon tianon mentioned this pull request May 21, 2018
Merged
@tianon
Copy link
Member Author

tianon commented May 21, 2018

I tested with both Dockerfiles from #208's description, and they both still build successfully (and rake is in PATH after the build, and I'm able to gem install passenger and get passenger-config in PATH, which is how we noticed this breakage in the first place).

tianon added a commit to infosiftr/stackbrew that referenced this pull request May 21, 2018
@tianon
Revert ruby updates for now
bc8c9fd 
See docker-library/ruby#209
@tianon
Copy link
Member Author

tianon commented May 21, 2018

I wonder if this means we should at least partially revert docker-library/docs#1221 too? I guess it's still pretty relevant.

@tianon tianon force-pushed the remove-bundle-bin branch 2 times, most recently from 928d3bc to 0c8dfb3 Compare May 21, 2018 22:28
@tianon
Copy link
Member Author

tianon commented May 21, 2018

Yay green finally!

@tianon tianon force-pushed the remove-bundle-bin branch from 0c8dfb3 to af6210c Compare May 22, 2018 21:36
@tianon tianon force-pushed the remove-bundle-bin branch from af6210c to 699a043 Compare May 23, 2018 17:00
@mvisonneau mvisonneau mentioned this pull request May 24, 2018
Closed
@mvisonneau
Copy link

Thanks for the fix @tianon. Any idea when this is going to be merged and released ? I believe that a lot of people are going to be impacted by the recent release on most tags that breaks the gems binary path.

@fwininger fwininger mentioned this pull request May 24, 2018
Closed
@henrytk henrytk mentioned this pull request May 24, 2018
Merged
bandesz added a commit to alphagov/paas-docker-cloudfoundry-tools that referenced this pull request May 24, 2018
@bandesz
Add /usr/local/bundle/bin to the path in the cf-uaac image
ab83122 
In the latest Ruby alpine image they removed the /usr/local/bundle/bin path
from the PATH which causes installed gem binaries not to be on the path
anymore.

We need to temporarily fix this until they sort out
docker-library/ruby#209.
bandesz added a commit to alphagov/paas-docker-cloudfoundry-tools that referenced this pull request May 24, 2018
@bandesz
Add /usr/local/bundle/bin to the path in the cf-uaac image
38704e5 
In the latest Ruby alpine image they removed the /usr/local/bundle/bin path
from the PATH which causes installed gem binaries not to be on the path
anymore.

We need to temporarily fix this until they sort out
docker-library/ruby#209.
@tianon
Copy link
Member Author

tianon commented May 24, 2018

Doh, good point; @yosifkit can you review this ASAP today? 😇

@yosifkit yosifkit merged commit 377b3e6 into docker-library:master May 24, 2018
@yosifkit yosifkit deleted the remove-bundle-bin branch May 24, 2018 16:34
@mvisonneau
Copy link

thanks 🙏 !

@tianon tianon mentioned this pull request May 24, 2018
Merged
tianon added a commit to infosiftr/stackbrew that referenced this pull request May 24, 2018
@tianon
Update docker-library images
3435bc7 
- `drupal`: new arches (thanks to Alpine 3.4 deprecation)
- `redmine`: update Redmine 3.3 to Ruby 2.3, remove Redmine 3.2 (docker-library/redmine#115)
- `ruby`: remove `BUNDLE_BIN`, adjust `PATH` (docker-library/ruby#209)
- `wordpress`: new arches (thanks to Alpine 3.4 deprecation)
This was referenced May 24, 2018
Merged
Closed
@yosifkit yosifkit mentioned this pull request May 24, 2018
Closed
@tianon tianon mentioned this pull request May 24, 2018
Merged
@Mehonoshin
Copy link

It looks like dockerhub still contains broken images.

I get the following with the latest image from there

 /bin/sh: 1: rails: not found
The command '/bin/sh -c rails assets:precompile' returned a non-zero code: 127

@Mehonoshin
Copy link

It looks like it does not work when I use bundle install --deployment --without development test
With regular, full installation it works.
@tianon do you have any ideas, why could that happen?

@tianon
Copy link
Member Author

tianon commented May 29, 2018

Gah, bundle install --deployment drops bits into ./vendor/bundle/... instead of the normal Bundler directory. 😞

From https://bundler.io/v1.0/man/bundle-install.1.html#DEPLOYMENT-MODE:

Gems are installed to vendor/bundle not your default system location

Was BUNDLE_BIN putting even those binstubs in /usr/local/bundler/bin before?

@Mehonoshin
Copy link

yep, it worked before

shibukk added a commit to shibukk/rails_application_template that referenced this pull request Jul 20, 2018
@shibukk
fix docker-library/ruby#209
6758d93
shibukk added a commit to shibukk/rails_simple_template that referenced this pull request Jul 20, 2018
@shibukk
fix docker-library/ruby#209
214305f
@eanlain eanlain mentioned this pull request Jul 20, 2018
Closed
@bkeroackdsc
Copy link

Any chance we can get this applied to the ruby 2.1.x image as well?

@tianon
Copy link
Member Author

tianon commented Sep 14, 2018 via email

@bkeroackdsc
Copy link

Fair enough. Thanks for the response!

@tianon tianon mentioned this pull request May 8, 2020
Closed
flavorjones added a commit to sparklemotion/nokogiri that referenced this pull request Jun 7, 2020
@flavorjones
ci: deal with jruby docker image conventions
ab0255e 
which create binstubs that set BUNDLER_GEMFILE

see rubygems/bundler#6162
see rubygems/bundler#6154
and see docker-library/ruby#209 which was the fix for cruby docker images
flavorjones added a commit to sparklemotion/nokogiri that referenced this pull request Aug 31, 2020
@flavorjones
ci: looks like we don't need to set BUNDLER_GEMFILE anymore
1ae26a6 
previously we had to because of these bugs:

bundler:
- rubygems/bundler#6162
- rubygems/bundler#6154

cruby docker:
- docker-library/ruby#209
- docker-library/ruby#306

jruby docker:
- jruby/docker-jruby#65
- https://github.com/cpuguy83/docker-jruby/pull/67/files
Earlopain added a commit to Earlopain/official-images-docs that referenced this pull request Jul 5, 2024
@Earlopain
Drop mentions of unused bundler env variables for ruby
58a0c0d 
Dropped in:
* docker-library/ruby#209
* docker-library/ruby#306
@Earlopain Earlopain mentioned this pull request Jul 5, 2024
Merged
tianon pushed a commit to docker-library/docs that referenced this pull request Jul 8, 2024
@Earlopain
Update examples from "ruby:3.0" to "ruby:3.3" (#2463)
2686af4 
* Update examples from "ruby:3.0" to "ruby:3.3"

Previous: #2051

3.0 images are not build/updated anymore

* Drop mentions of unused bundler env variables for ruby

Dropped in:
* docker-library/ruby#209
* docker-library/ruby#306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tianon @mvisonneau @Mehonoshin @bkeroackdsc @kaikuchn @thebigw4lrus @yosifkit