2.7/alpine3.7: Add nis libraries now that 2.7.15 is patched #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayH5
commented
Apr 30, 2018
| @@ -47,12 +47,12 @@ RUN set -ex \ | |||
| libc-dev \ | |||
| libffi-dev \ | |||
| libnsl-dev \ | |||
| openssl \ | |||
| openssl-dev \ | |||
There was a problem hiding this comment.
I realize this now makes the openssl libs "unsorted", but the openssl builds should go away soon. Alpine 3.4 is being deprecated has been removed and Alpine 3.8's libressl should be supported by Python 3.7.
JayH5
force-pushed
the
py2.7-alpine3.7-nis
branch
from
705f4a0
to
8d755d1
Compare
yosifkit
approved these changes
Jun 4, 2018
There was a problem hiding this comment.
Adding libnsl and libtirpc seems fine to me since this follows the same logic used in the python:3.x images:
Lines 162 to 164 in f38c92b
Sorting of ssl library is fine as well (more correct in more places).
|
Size difference for reference |
tianon
approved these changes
Jun 5, 2018
|
Also relevant: https://github.com/tiran/peps/blob/ba2635cb59cd97264905ce32ef85f9456c1a5297/pep-9999.rst#nis (movement in Python upstream to remove |
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Jun 5, 2018
- `bash`: 4.4.23 - `ghost`: 1.23.1 - `julia`: 0.6.3 - `matomo`: GPG race conditions (matomo-org/docker#105) - `memcached`: `extstore` (docker-library/memcached#38) - `mongo`: 4.0.0~rc2 - `openjdk`: remove 9 (docker-library/openjdk#199), add 10 for Windows (docker-library/openjdk#200), 11-ea+16 - `owncloud`: update PECL exts (docker-library/owncloud#102) - `percona`: 5.7.22, 5.6.40 - `php`: fix `wget: error getting response: Connection reset by peer` - `piwik`: GPG race conditions (matomo-org/docker#105) - `python`: add `nis` nonsense to 2.7 (docker-library/python#281), 3.7.0b5 - `rocket.chat`: 0.65.1 - `ruby`: 2.6.0-preview2 - `wordpress`: update GPG for wp-cli
tao12345666333
pushed a commit
to tao12345666333/python
that referenced
this pull request
Jun 28, 2018
2.7/alpine3.7: Add nis libraries now that 2.7.15 is patched
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final fix for #247.