Update generated "pg_hba.conf" content for IPv6 support #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosifkit
reviewed
Oct 11, 2016
| @@ -43,6 +43,8 @@ if [ "$1" = 'postgres' ]; then | |||
| fi | |||
|
|
|||
| { echo; echo "host all all 0.0.0.0/0 $authMethod"; } >> "$PGDATA/pg_hba.conf" | |||
| { echo; echo "host all all ::/0 $authMethod"; } >> "$PGDATA/pg_hba.conf" | |||
There was a problem hiding this comment.
It might be simpler to just use all for the address; then we only add one line to hba.conf.
You can also write all to match any IP address, samehost to match any of the server's own IP addresses, or samenet to match any address in any subnet that the server is directly connected to.
https://www.postgresql.org/docs/9.3/static/auth-pg-hba-conf.html
(also, can you remove the extra blank line added below)
There was a problem hiding this comment.
Nice, "all" seems like better solution, thank you. Also, extra blank line was removed :-)
tianon
changed the title
yosifkit
approved these changes
Oct 12, 2016
IPv6 default rule added into pg_hba.conf The "all" keyword instead of the IP notation
|
Rebased and ran LGTM, thanks! |
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Dec 6, 2016
- `golang`: update Windows Git to 2.11.0 (docker-library/golang#126) - `php`: fix subshell usage (docker-library/php#334) - `postgres`: update `pg_hba.conf` for IPv6 support (docker-library/postgres#202) - `rocket.chat`: 0.47.0 - `wordpress`: 4.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPv6 default rule added into pg_hba.conf