Add cflags and ldflags for security and portability #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
M-m-m-m-merrrrge conflict! |
|
rebased! |
|
Regarding placement, yeah, we don't really compile anything above those lines, so that seems sane. 👍 Do you think it'd make sense to include a link back to #272 (or elsewhere if there's a better reference for why these things are good)? |
tianon
approved these changes
Dec 5, 2016
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Dec 6, 2016
- `django`: 1.10.4 - `docker`: 1.13.0-rc3 - `httpd`: nghttp2 1.17.0-1 - `java`: debian 9~b147-1 - `openjdk`: debian 9~b147-1 - `php`: 7.1 GA (docker-library/php#342), updated `CFLAGS` (docker-library/php#340) - `redis`: 3.2.6 - `ruby`: 2.4.0-preview3 (docker-library/ruby#93)
This was referenced Dec 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #272
I think this is the most optimal spot for these
ENVlines, but I am open to suggestions.