Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now-defunct 8u and 11u builds #510

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

tianon
Copy link
Member

@tianon tianon commented Aug 3, 2022

See https://github.com/AdoptOpenJDK/openjdk8-upstream-binaries#readme and https://github.com/AdoptOpenJDK/openjdk11-upstream-binaries#readme 🙇

To be 100% explicitly clear: 8u and 11u are still maintained releases, they are just no longer provided here. Please find alternatives (Eclipse Temurin, etc) if you wish to continue using them.

Once Oracle stops publishing OpenJDK 18 builds, those will also be removed, and 19+ will be removed as soon as each release hits GA (as discussed previously).

From this point forward, our focus is on publishing only the EA builds from Oracle (since none of the other Java-providing official images currently do so).

@tianon
Copy link
Member Author

tianon commented Aug 3, 2022

(Draft waiting for AdoptOpenJDK/openjdk11-upstream-binaries#28 👀 ❤️)

@gdams
Copy link

gdams commented Aug 4, 2022

@tianon is it worth swapping these images to contain the Eclipse Temurin binaries? They are almost identical. I assume that a pretty large number of people rely on these images so it concerns me that they may be broken.

@tianon
Copy link
Member Author

tianon commented Aug 4, 2022

@gdams yeah, from a usability perspective, I'd absolutely agree -- unfortunately, I don't feel comfortable publishing Temurin as "official OpenJDK" (there are some pretty dramatic threads you can find in this repository if you want to read some of the history about which builds we've used in the past and the disagreements it has caused) 😞

@gdams
Copy link

gdams commented Aug 4, 2022

@tianon so here's my 2 cents...

The original discussions that you're referring to were about using AdoptOpenJDK as the openjdk base image. Several concerns were raised (mainly that AdoptOpenJDK wasn't able to TCK the binaries that they built)

Eclipse Temurin is in a very different position. It's hosted by an Open Source software foundation and passes the TCK tests that are required to confirm that the binary is compliant with the Java specification.

To quote the official docker guidelines outlines in https://github.com/docker-library/official-images#what-are-official-images, two of the tenets are a focus on Free and Open-Source software and multiple architecture support. Eclipse Temurin is therefore likely the most suitable drop-in replacement especially given the Synk Java ecosystem report that was shared in a related issue recently.

I'm certainly not suggesting that we should continue to maintain the openjdk image but I'm considered about the ramifications of deprecating a cast with 1B+ pulls. My suggestion ideally would be to simply redirect the users that are expecting the latest version to a similar (likely Temurin) container. E.g openjdk:8 would redirect to eclipse-temurin:8 for users expecting the "latest openjdk 8 build".

@tianon
Copy link
Member Author

tianon commented Aug 4, 2022

I'm referring to some of the older concerns/discussions (#320, for example) -- I definitely won't personally be making any new decisions about what to publish as "OpenJDK" in the future. 😅

I'd love to do some kind of redirect, but the container pulling APIs don't support it (the message that's currently on https://hub.docker.com/_/openjdk is the best we can do).

@gdams
Copy link

gdams commented Aug 4, 2022

I'd love to do some kind of redirect, but the container pulling APIs don't support it (the message that's currently on https://hub.docker.com/_/openjdk is the best we can do).

Could you not create a simple Dockerfile that essentially contains the other base image and tag this as openjdk:11?

FROM eclipse-temurin:11
CMD ["jshell"]

That way when people go to use what they believe to be the latest they will at least get a patched version of OpenJDK?

@tianon
Copy link
Member Author

tianon commented Aug 4, 2022

Yes, absolutely, that's exactly how I would probably implement this if I were going to do so 😅

What I'm trying to say is that the problems with us doing so are not technical, they are political 🙈

See https://github.com/AdoptOpenJDK/openjdk8-upstream-binaries#readme and https://github.com/AdoptOpenJDK/openjdk11-upstream-binaries#readme 🙇

To be 100% explicitly clear: 8u and 11u *are still maintained releases*, they are just no longer provided here.  Please find alternatives (Eclipse Temurin, etc) if you wish to continue using them.

Once Oracle stops publishing OpenJDK 18 builds, those will also be removed, and 19+ will be removed as soon as each release hits GA (as discussed previously).

From this point forward, our focus is on publishing only the EA builds from Oracle (since none of the other Java-providing official images currently do so).
@tianon tianon marked this pull request as ready for review August 16, 2022 22:11
@tianon tianon merged commit 241c62f into docker-library:master Aug 17, 2022
@tianon tianon deleted the orphanjdk branch August 17, 2022 00:22
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Aug 17, 2022
Changes:

- docker-library/openjdk@241c62f: Merge pull request docker-library/openjdk#510 from infosiftr/orphanjdk
- docker-library/openjdk@f9cf605: Remove now-defunct 8u and 11u builds
- docker-library/openjdk@837d7bc: Update 20 to 20-ea+10
- docker-library/openjdk@afc6de3: Update 19 to 19
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Aug 18, 2022
Changes:

- docker-library/openjdk@4b928d2: Update 18 to 18.0.2.1
- docker-library/openjdk@241c62f: Merge pull request docker-library/openjdk#510 from infosiftr/orphanjdk
- docker-library/openjdk@f9cf605: Remove now-defunct 8u and 11u builds
- docker-library/openjdk@837d7bc: Update 20 to 20-ea+10
- docker-library/openjdk@afc6de3: Update 19 to 19
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Aug 19, 2022
Changes:

- docker-library/openjdk@045b903: Update 20 to 20-ea+11
- docker-library/openjdk@6e4c15a: Update 19
- docker-library/openjdk@4b928d2: Update 18 to 18.0.2.1
- docker-library/openjdk@241c62f: Merge pull request docker-library/openjdk#510 from infosiftr/orphanjdk
- docker-library/openjdk@f9cf605: Remove now-defunct 8u and 11u builds
- docker-library/openjdk@837d7bc: Update 20 to 20-ea+10
- docker-library/openjdk@afc6de3: Update 19 to 19
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Aug 19, 2022
Changes:

- docker-library/openjdk@307daaf: Merge pull request docker-library/openjdk#511 from infosiftr/rc-suffix
- docker-library/openjdk@f67fe7f: Add "-rc" suffix to only-digit version numbers
- docker-library/openjdk@045b903: Update 20 to 20-ea+11
- docker-library/openjdk@6e4c15a: Update 19
- docker-library/openjdk@4b928d2: Update 18 to 18.0.2.1
- docker-library/openjdk@241c62f: Merge pull request docker-library/openjdk#510 from infosiftr/orphanjdk
- docker-library/openjdk@f9cf605: Remove now-defunct 8u and 11u builds
- docker-library/openjdk@837d7bc: Update 20 to 20-ea+10
- docker-library/openjdk@afc6de3: Update 19 to 19
@yosifkit yosifkit mentioned this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants